fix: log full error object in logerror (fixes #6462)#7290
Open
myselfsiddharth wants to merge 1 commit into
Open
fix: log full error object in logerror (fixes #6462)#7290myselfsiddharth wants to merge 1 commit into
myselfsiddharth wants to merge 1 commit into
Conversation
Use console.error(err) instead of err.stack || err.toString() so Node's built-in error inspection includes Error.cause, custom properties (e.g. Sequelize parent/original), and AggregateError details. Adds regression test for the default error handler logging path. Fixes expressjs#6462 Related: expressjs#6464 (same one-line fix; this PR adds test coverage and is rebased on current master) Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
cc @Nitin-Mohapatra — happy to help rebase #6464 or fold this test into that PR if maintainers prefer a single PR. |
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
logerrorinlib/application.jsto useconsole.error(err)instead ofconsole.error(err.stack || err.toString()), so Node's built-in error inspection preservesError.cause, custom enumerable properties (e.g. Sequelizeparent/original), andAggregateErrordetails.This matches the approach in #6464 (approved in review; vestigial
err.stackworkaround from pre-Node-18 whenconsole.error(err)did not print stacks). Express 5 already requires Node >= 18.This PR is rebased on current
masterand adds regression test coverage (test/app.logerror.js) for the default error handler logging path.Fixes #6462
Related PRs
Test plan
npm test -- test/app.logerror.jsnpm test(1250 passing)Behavior note
Only affects stderr when the default error handler runs and
env !== 'test'. HTTP responses are unchanged.