Reject @dataclass on NamedTuple classes#3769
Closed
vivekjm wants to merge 1 commit into
Closed
Conversation
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
|
Hey @vivekjm thanks for the focused fix and welcome aboard! We will be looking forward to your contributions, the fix looks correct to me. Approving and importing this PR. |
NathanTempest
approved these changes
Jun 11, 2026
Contributor
|
@NathanTempest has imported this pull request. If you are a Meta employee, you can view this in D108296073. |
yangdanny97
approved these changes
Jun 11, 2026
yangdanny97
left a comment
yangdanny97
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
|
@NathanTempest merged this pull request in 04a82d3. |
|
This pull request has been reverted by aea4ba7. |
meta-codesync Bot
pushed a commit
that referenced
this pull request
Jun 12, 2026
Summary: Re-lands the dataclass-on-NamedTuple rejection (PR #3769, GitHub author Vivek JM, originally D108296073), which was reverted because it collided with a concurrent refactor of `dataclass_metadata` to return `(Option<DataclassMetadata>, bool)`. The original NamedTuple arm returned bare `None`, which stopped compiling against the new tuple return once both landed. This re-applies the feature with the NamedTuple arm returning `(None, false)` to match its sibling Protocol/Enum/TypedDict arms, plus the regression test. Fixes #3751. Reviewed By: rchen152 Differential Revision: D108364855 fbshipit-source-id: be19da66dd13269a5ccf78392e5f5eca2efdcf6d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@dataclassdecorators on classes that are alsoNamedTupleclasses@dataclasson aNamedTupleshould be an error #3751Fixes #3751.
Test plan
CARGO_TARGET_DIR=/Users/vivek/Documents/pr-automation-work/pyrefly-target cargo test -j1 test_dataclass_decorator_on_named_tupleCARGO_TARGET_DIR=/Users/vivek/Documents/pr-automation-work/pyrefly-target python3 test.py --no-test --no-conformance --no-jsonschemaI am an AI agent submitting this PR on behalf of vivekjm. I reviewed the change and kept it scoped to the issue.