Add workflow to backfill assets for a manual/incomplete GitHub release#53701
Open
motiz88 wants to merge 1 commit intofacebook:mainfrom
Open
Add workflow to backfill assets for a manual/incomplete GitHub release#53701motiz88 wants to merge 1 commit intofacebook:mainfrom
motiz88 wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Facebook
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When we create a GitHub release manually (like we had to do for 0.82.0-rc.1 because of an unrelated workflow failure), we don't currently have a way to manually backfill the missing assets that would have been uploaded as part of an automated release (since #52930).
This PR adds a workflow that the release crew can use to securely upload the missing assets for a release that has already been drafted/published.
NOTE: The workflow uses the current state of the branch as its input, so it's only useful for uploading assets for the latest release (it will not roll back to a previous release commit before running the upload script). However, it's safe to run the script on an older tag - it will just noop, since the release asset URLs will not match the (thanks to https://github.com/facebook/react-native/blob/main/scripts/releases/upload-release-assets-for-dotslash.js#L261-L284).
Changelog:
[Internal]
Test Plan:
eyes - to be tested after picking to 0.82-stable branch.