[Hermes][iOS] Remove RCT_HERMES_V1_ENABLED from CocoaPods infrastructure#56701
Draft
cipolleschi wants to merge 1 commit intocipolleschi/remove-legacy-hermes-phase2from
Draft
Conversation
Remove the RCT_HERMES_V1_ENABLED environment variable and all conditional logic in the CocoaPods/Ruby files. The podspec now always reads HERMES_VERSION_NAME, uses V1 source files, and omits legacy inspector subspecs. The HERMES_V1_ENABLED=1 preprocessor define is no longer set since no C++ code checks for it.
meta-cla
Bot
added
the
CLA Signed
|
Caution Invalid Base Branch The base branch for this PR is |
cipolleschi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RCT_HERMES_V1_ENABLEDenvironment variable fromreact_native_pods.rbjsengine.rbto always use.hermesversiontag fileHERMES_V1_ENABLED=1preprocessor definition fromutils.rbhermes-engine.podspec: always readHERMES_VERSION_NAME, use V1 source files, remove legacy inspector subspecshermes-utils.rb: removehermes_v1_enabled()function, always use250829098.0.0-stablebranch, always use.hermesversiontag fileChangelog:
[iOS][Removed] - Remove the RCT_HERMES_V1_ENABLED from Cocoapods
Test plan
bundle exec pod install— successxcodebuildrn-tester on iPhone 16 Pro simulator — BUILD SUCCEEDED