[Hermes][JS] Consolidate Hermes version files and simplify JS release scripts#56703
Draft
cipolleschi wants to merge 1 commit intocipolleschi/remove-legacy-hermes-phase3from
Draft
Conversation
Remove dual .hermesversion/.hermesv1version tag files — only .hermesversion remains. Simplify hermes-utils.js to single-tag operations, release scripts to single-version workflows, and bump-hermes-version.js to single Hermes. Remove legacy branch handling from release-hermes-for-branch-cut.js.
meta-cla
Bot
added
the
CLA Signed
|
Caution Invalid Base Branch The base branch for this PR is |
cipolleschi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sdks/.hermesv1versionfrompackage.jsonfiles array — only.hermesversionremainshermes-utils.js: removereadHermesV1Tag(),HERMES_V1_TAG_FILE_PATH;setHermesTag()takes single argumentscripts/releases/utils/hermes-utils.js: single version ingetLatestHermesNightlyVersion()andupdateHermesRuntimeDependenciesVersions()bump-hermes-version.js: remove--v1-tagand--hermes-v1-versionCLI optionsrelease-hermes-for-branch-cut.js: remove legacy branch/workflow/PR logic, keep only single Hermes branchChangelog:
[General][Changed] - Simplified build JS Hermes infrastructure for the Release
Test plan
yarn jest --no-watchman hermes-utils-test.js— 5/5 tests pass