fix(devtools): clear highlight when mouse leaves DevTools panel#36177
fix(devtools): clear highlight when mouse leaves DevTools panel#36177petertdinh wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Hi @petertdinh! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Fixes #17855
When hovering a component in the DevTools Components inspector, a highlight overlay appears on the inspected page. The highlight is cleared via
onMouseLeaveon the tree containerdiv. But this React synthetic event only fires when the pointer transitions between elements within the same document. When the user moves their mouse out of the DevTools panel window entirely (e.g. to the browser viewport), no element in the React tree receivesmouseleave, soclearHostInstanceHighlightis never sent over the bridge and the overlay persists on the page.The fix adds a native
mouseleavelistener on the DevTools panel'sownerDocumentinTree.js. When the pointer exits the panel viewport, it firesclearHighlightHostInstanceand removes the overlay. UsingownerDocument(rather than document) is consistent with the existing pattern inTree.jsfor browser extension compatibility.How did you test this change?
Tested manually using the Chrome extension:
Ran the DevTools test suite: yarn test --no-watchman ReactDevTools — all tests pass.