Skip to content

Conversation

@Fonzie-byte
Copy link

@Fonzie-byte Fonzie-byte commented Jul 9, 2025

Motivation / Background

This Pull Request has been created because a generator for Dutch national ID numbers (called Burger Service Nummer, or BSN for short) was missing.

I know you are not looking for new generators, but I hope you will still consider something this useful.

Additional information

Sample terminal output:

Sample terminal output of the IdNumer.dutch_bsn generator

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator or locale:

  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Contributing guidelines.


PLATFORMS
arm64-darwin-22
arm64-darwin-24
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added automatically, and I try to refrain from manually removing lines from the lock file.

Question for the Faker maintainers: Should this change be removed or let it?

@stefannibrasil
Copy link
Contributor

Hi @Fonzie-byte Thanks for your contribution. I know working on Open Source requires valuable time.

At the moment, we won't accept this because we are not introducing new/significant changes to existing generators. @thdaraujo and I are currently exploring different ways of loading the generators with the expectation to give the community the option to create their own generators/custom options without merging them in faker. This would reduce our load (we have lots of generators to update, maintain, etc.) while providing flexibility to users by adding external plugins.

Once we have this going, I will let you know and you can contribute to faker by adding this option as a plugin. Closing in the meantime since we are focused on improving the existing ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants