Skip to content

Conversation

@jclusso
Copy link

@jclusso jclusso commented Dec 9, 2025

Motivation / Background

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

- Added support to pass `provider`. This is useful if you don't use the default provider name
- Added support for microsoft: https://github.com/pond/omniauth-entra-id
- Added support for oidc: https://github.com/omniauth/omniauth_openid_connect
@stefannibrasil
Copy link
Contributor

stefannibrasil commented Jan 12, 2026

Hi @jclusso Thanks for your contribution. I know working on Open Source requires valuable time.

At the moment, we won't accept this because we are not introducing new/significant changes to existing generators. @thdaraujo and I are currently exploring different ways of loading the generators with the expectation to give the community the option to create their own generators/custom options without merging them in faker. This would reduce our load (we have lots of generators to update, maintain, etc.) while providing flexibility to users by adding external plugins.

Once we have this going, I will let you know and you can contribute to faker by adding this option as a plugin. Closing in the meantime since we are focused on improving the existing ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants