Skip to content

Fix: qualify bare Faker constant references to support lazy loading #3253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefannibrasil merged 1 commit into from
Apr 27, 2026
+11 −11
Merged

Fix: qualify bare Faker constant references to support lazy loading #3253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/faker/default/code.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def ean(base: 13)
#
# @faker.version 1.9.4
def rut
value = Number.number(digits: 8).to_s
value = Faker::Number.number(digits: 8).to_s
vd = rut_verificator_digit(value)
value << "-#{vd}"
end
Expand All @@ -92,7 +92,7 @@ def rut
#
# @faker.version 2.2.0
def nric(min_age: 18, max_age: 65)
birthyear = Date.birthday(min_age: min_age, max_age: max_age).year
birthyear = Faker::Date.birthday(min_age: min_age, max_age: max_age).year

generate(:string) do |g|
g.computed(name: :prefix) do
Expand Down
8 changes: 4 additions & 4 deletions lib/faker/default/crypto.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class << self
#
# @faker.version 1.6.4
def md5
OpenSSL::Digest::MD5.hexdigest(Lorem.characters(number: MD5_MIN_NUMBER_OF_CHARACTERS))
OpenSSL::Digest::MD5.hexdigest(Faker::Lorem.characters(number: MD5_MIN_NUMBER_OF_CHARACTERS))
end

##
Expand All @@ -35,7 +35,7 @@ def md5
#
# @faker.version 1.6.4
def sha1
OpenSSL::Digest::SHA1.hexdigest(Lorem.characters(number: SHA1_MIN_NUMBER_OF_CHARACTERS))
OpenSSL::Digest::SHA1.hexdigest(Faker::Lorem.characters(number: SHA1_MIN_NUMBER_OF_CHARACTERS))
end

##
Expand All @@ -48,7 +48,7 @@ def sha1
#
# @faker.version 1.6.4
def sha256
OpenSSL::Digest::SHA256.hexdigest(Lorem.characters(number: SHA256_MIN_NUMBER_OF_CHARACTERS))
OpenSSL::Digest::SHA256.hexdigest(Faker::Lorem.characters(number: SHA256_MIN_NUMBER_OF_CHARACTERS))
end

##
Expand All @@ -61,7 +61,7 @@ def sha256
#
# @faker.version next
def sha512
OpenSSL::Digest::SHA512.hexdigest(Lorem.characters(number: SHA512_MIN_NUMBER_OF_CHARACTERS))
OpenSSL::Digest::SHA512.hexdigest(Faker::Lorem.characters(number: SHA512_MIN_NUMBER_OF_CHARACTERS))
end
end
end
Expand Down
8 changes: 4 additions & 4 deletions lib/faker/default/omniauth.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def facebook(name: nil, email: nil, username: nil, uid: Faker::Number.number(dig
},
credentials: {
token: Faker::Crypto.md5,
expires_at: Time.forward.to_i,
expires_at: Faker::Time.forward.to_i,
expires: true
},
extra: {
Expand Down Expand Up @@ -263,8 +263,8 @@ def linkedin(name: nil, email: nil, uid: Faker::Number.number(digits: 6).to_s)
params: {
oauth_token: token,
oauth_token_secret: secret,
oauth_expires_in: Time.forward.to_i,
oauth_authorization_expires_in: Time.forward.to_i
oauth_expires_in: Faker::Time.forward.to_i,
oauth_authorization_expires_in: Faker::Time.forward.to_i
},
response: nil
},
Expand Down Expand Up @@ -420,7 +420,7 @@ def auth0(name: nil, email: nil, uid: nil)
image: image
},
credentials: {
expires_at: Time.forward.to_i,
expires_at: Faker::Time.forward.to_i,
expires: true,
token_type: 'Bearer',
id_token: Faker::Crypto.sha256,
Expand Down
2 changes: 1 addition & 1 deletion lib/faker/default/types.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def rb_integer(from: 0, to: 100)
# @faker.version 1.8.6
def rb_hash(number: 1, type: -> { random_type })
{}.tap do |hsh|
Lorem.words(number: number * 2).uniq.first(number).each do |s|
Faker::Lorem.words(number: number * 2).uniq.first(number).each do |s|
value = type.is_a?(Proc) ? type.call : type
hsh.merge!(s.to_sym => value)
end
Expand Down