Open
Conversation
svlandeg
commented
Mar 10, 2026
| def downgrade(): | ||
| # ### commands auto generated by Alembic - please adjust! ### | ||
| op.drop_constraint(None, 'item', type_='foreignkey') | ||
| op.drop_constraint('item_owner_id_fkey', 'item', type_='foreignkey') |
Member
Author
There was a problem hiding this comment.
A little confused about this one, as drop_constraint requires a str constraint name. Not sure why it was None before and I don't see how it would have worked. Feels like this is an actual bug fix? 🤔
svlandeg
commented
Mar 10, 2026
alejsdev
approved these changes
Mar 12, 2026
svlandeg
commented
Mar 17, 2026
svlandeg
commented
Mar 27, 2026
Member
Author
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
@alejsdev : by bumping to ty 0.0.25, we're able to have less ignore statements when combining mypy with ty, cf this edit. So I think that's nice! I also changed the settings to error on warning, as discussed with Sebastián - we'll do this for all our repos. So this should be in a good state to review/merge (again) now 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tyto pyproject, lint.sh & precommittyhappy