chore(web): upgrade vite-plus and related packages to 0.1.13#4
Conversation
- vite-plus: 0.1.12 → 0.1.13 - @voidzero-dev/vite-plus-core: 0.1.12 → 0.1.13 - @voidzero-dev/vite-plus-test: 0.1.12 → 0.1.13 - @storybook/nextjs-vite: 10.3.0 → 10.3.1
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining the project's frontend dependencies by upgrading Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request upgrades vite-plus and related packages to version 0.1.13, and @storybook/nextjs-vite to 10.3.1. The changes are consistent with the PR description. However, I've identified a potential peer dependency issue with the Storybook package updates. While @storybook/nextjs-vite is updated, other Storybook packages are not, which could lead to conflicts. Please see the specific comment for details.
| "@storybook/addon-onboarding": "10.3.0", | ||
| "@storybook/addon-themes": "10.3.0", | ||
| "@storybook/nextjs-vite": "10.3.0", | ||
| "@storybook/nextjs-vite": "10.3.1", |
There was a problem hiding this comment.
You've updated @storybook/nextjs-vite to 10.3.1, but other @storybook/* packages remain at 10.3.0. The new version of @storybook/nextjs-vite has a peer dependency on storybook@^10.3.1, which is not met by the currently installed version 10.3.0. This can cause peer dependency conflicts and potential issues. It's recommended to update all related @storybook/* packages to the same version to ensure compatibility.
For example:
"@storybook/addon-docs": "10.3.1",
"@storybook/addon-links": "10.3.1",
"@storybook/addon-onboarding": "10.3.1",
"@storybook/addon-themes": "10.3.1",
"@storybook/nextjs-vite": "10.3.1",
"@storybook/react": "10.3.1",
...
"eslint-plugin-storybook": "10.3.1",
...
"storybook": "10.3.1"
Important
Fixes #<issue number>.Summary
Screenshots
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods