Conversation
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a package version timeline chart, a "Likes Leaderboard" page with supporting API logic, and a new "Press" noodle logo. Key UI enhancements include dynamic chart tooltip positioning, top-liked badges on package pages, and improved README copy functionality with loading states. The changes also encompass dependency updates, the addition of the Portuguese (Portugal) locale, and extensive typo and grammar fixes. Feedback identifies a bug in the TimelineChart where version tracking fails due to incorrect route parameter usage, alongside suggestions to improve tooltip readability by adjusting background opacity and to correct an invalid CSS deep selector.
| const { settings } = useSettings() | ||
| const route = useRoute('timeline') | ||
| const chartRef = useTemplateRef('chartRef') | ||
| const activeVersion = computed(() => route.params.version) |
There was a problem hiding this comment.
The activeVersion is computed from route.params.version, but the timeline route (app/pages/package-timeline/[[org]]/[packageName].vue) does not have a version parameter. This results in activeVersion being undefined, which prevents the "Marker for selected version" circle from being displayed on the chart. Since the parent component manages the selected version via the selectedVersion prop, this computed property should use that prop instead.
const activeVersion = computed(() => props.selectedVersion)
| borderColor: colors.value.border, | ||
| borderRadius: 6, | ||
| backgroundColor: colors.value.bg, | ||
| backgroundOpacity: 10, |
There was a problem hiding this comment.
A backgroundOpacity of 10 (10%) for the tooltip might be too transparent, making the text difficult to read when it overlaps with chart grid lines or data points. Consider increasing the opacity for better readability, or setting it to 0 if the background is intended to be handled entirely by the custom tooltip template's CSS.
| } | ||
|
|
||
| @media (prefers-reduced-motion: reduce) { | ||
| ::deep(.vue-data-ui-component .serie_line_0 path), |
There was a problem hiding this comment.
The CSS selector ::deep is invalid. Vue's SFC style blocks use the :deep() pseudo-class for deep selectors.
:deep(.vue-data-ui-component .serie_line_0 path),
e18e dependency analysisNo dependency warnings found. |
1 participant
Upgrade vite-plus and related packages to the pkg-pr-new test build from voidzero-dev/vite-plus#1538 (commit f8973e4).
Upstream PR: voidzero-dev/vite-plus#1538