fix: check for body type before parsePush execution#1511
fix: check for body type before parsePush execution#1511jescalada wants to merge 6 commits intofinos:mainfrom
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (33.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1511 +/- ##
==========================================
- Coverage 90.21% 90.18% -0.04%
==========================================
Files 69 69
Lines 5511 5514 +3
Branches 944 946 +2
==========================================
+ Hits 4972 4973 +1
- Misses 521 523 +2
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| - name: Publish git-proxy-plugin-samples | ||
| working-directory: plugins/git-proxy-plugin-samples | ||
| run: | | ||
| npm install --include=peer |
There was a problem hiding this comment.
This bit had to be removed in order to fix the "unpinned dependency" alert https://github.com/finos/git-proxy/security/code-scanning/113. I think this shouldn't cause issues since the published package wouldn't include the peer dep (finos/git-proxy) - unless I'm missing something 🤔
Pinging @coopernetes just in case!
There was a problem hiding this comment.
doesn't it just need switching to npm ci?
kriswest
left a comment
There was a problem hiding this comment.
Please update the PR title as scope is beyond whaats described, otherwise LGTM
Fixes #1509.