-
-
Notifications
You must be signed in to change notification settings - Fork 17
fix: improve performance by using caching #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: lennartrommeiss <[email protected]>
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: lennartrommeiss <[email protected]>
|
The most significant improvement would be, if we achieve to do the image processing only once per image. However we can't use partialCached for this, because this is still done once per language. So each image is processing twice at the moment, even if it's the same image (we don't have different images for different languages). Maybe @MoritzWeber0 has an idea? |
The image processing is automatically cached and only done once - prove me wrong. The detail lies in the sentence of the last paragraph:
When I have a look at the resources directory, I only see general images and images in the "en" directory. There is no additional "de" directory, so I'd assume that these images are no rerendered. Also, the images are already fetched from the |
|
No I mean during the build process. When running Every Country Flag (4) And all of this for each language. |
That makes sense. The partial is called for each language. The question is: Is the image processing inside the partial cached? So if I call the same image partial twice, it might resize the images the first time and the second time the expensive resizing step might be skipped and it's faster. I have to look at this again sometime. (In the worst case we can do the processing on our own and then ship the images via the static dir) |
Signed-off-by: lennartrommeiss <[email protected]>
Signed-off-by: lennartrommeiss <[email protected]>
Signed-off-by: lennartrommeiss <[email protected]>
Signed-off-by: lennartrommeiss <[email protected]>
Signed-off-by: lennartrommeiss <[email protected]>
Signed-off-by: lennartrommeiss <[email protected]>




Description
Improve the build performance by using partial caches
Checklist
The content was modified in the following languages: