fix: Remove padding of search highlight and unify bg-color #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
therobrob
reviewed
May 24, 2025
Member
therobrob
left a comment
therobrob
left a comment
There was a problem hiding this comment.
Do we really need the important flag?
Member
Author
The padding is part of the pagefind styles and I didn't find a good way to overwrite it in another way. |
MoritzWeber0
force-pushed
the
fix/search-highlight
branch
2 times, most recently
from
f3af515 to
30b1f97
Compare
Member
Author
Nevermind, I found a better way using a class with higher CSS specificity. |
MoritzWeber0
force-pushed
the
fix/search-highlight
branch
from
30b1f97 to
3a89eee
Compare
MoritzWeber0
added
technical
therobrob
approved these changes
May 26, 2025
lenderom
added a commit
that referenced
this pull request
May 27, 2025
The span in #145 was only added to the print version (due to a rebase / merge). This adds it to the normal version for which it was originally planned. It fixes the following display issue:  Co-authored-by: Lennart Rommeiss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #132