fix: Mark tel: links as safe
#189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…#188) Instead of having the copy icon directly after the text (which produced some issues with multi-line texts), always place the the copy icon on the right side. It's easier to reach for right-handed people. Not 100% sure if the link icon is still recognized with a connection to the title, so happy to hear any feedback. Resolves fipguide#49 Was originally approved in fipguide#177, but didn't target the correct branch. Here is another attempt to get it to the main branch.
By default, Hugo only allows using `http:`, `https:`, and `mailto:`. URLs using other schemes are replaced with `#ZgotmplZ`. To allow using `tel:`, we have to declare it as safe using `| safeURL`. This marks every URL as safe which should be fine, since all content inside the repo is trusted. See https://gohugo.io/functions/safe/url/ for more info. Closes fipguide#185
MoritzWeber0
approved these changes
Jun 9, 2025
Member
MoritzWeber0
added a commit
that referenced
this pull request
Jun 9, 2025
## Description By default, Hugo only allows using `http:`, `https:`, and `mailto:`. URLs using other schemes are replaced with `#ZgotmplZ`. To allow using `tel:`, we have to declare it as safe using `| safeURL`. This marks every URL as safe which should be fine, since all content inside the repo is trusted. See https://gohugo.io/functions/safe/url/ for more info. Closes #185 <!-- Add a short description here / Eine kurze Beschreibung hier einfügen --> ## Checklist <!-- Check fields with: [x] / Abhaken von Punkten: [x] --> - [x] Check the License of new pictures (non-commercial use without attribution) <!-- Die Lizenz neuer Bilder geprüft (nicht-kommerzielle Nutzung ohne Namensnennung) --> The content was modified in the following languages: <!-- Der Inhalt wurde für die folgenden Sprachen angepasst --> - [ ] English - [ ] German --------- Co-authored-by: Moritz Weber <[email protected]>
lenderom
pushed a commit
that referenced
this pull request
Jun 9, 2025
## Description By default, Hugo only allows using `http:`, `https:`, and `mailto:`. URLs using other schemes are replaced with `#ZgotmplZ`. To allow using `tel:`, we have to declare it as safe using `| safeURL`. This marks every URL as safe which should be fine, since all content inside the repo is trusted. See https://gohugo.io/functions/safe/url/ for more info. Closes #185 Originally merged into booking-shortcode in #189, but it's relevant for main already. Credit goes to @zusorio, I just reopened the PR. Co-authored-by: Tobias Messner <[email protected]>
MoritzWeber0
added
the
technical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default, Hugo only allows using
http:,https:, andmailto:. URLs using other schemes are replaced with#ZgotmplZ. To allow usingtel:, we have to declare it as safe using| safeURL. This marks every URL as safe which should be fine, since all content inside the repo is trusted.See https://gohugo.io/functions/safe/url/ for more info.
Closes #185
Checklist
The content was modified in the following languages: