feat: Improve dark mode #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed menu.html (see #257)
renamed logo.html
fip guide logo on dark
fip guide logo on dark
fallback for rss-feed
fallback for rss-feed
dark-mode for intersector.html
dark-mode for intersector.html
smaller improvements
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
smaller improvements
smaller improvements
Member
MoritzWeber0
left a comment
MoritzWeber0
left a comment
There was a problem hiding this comment.
Good improvement, I like the new color scheme. Thanks for adjusting the logo, that's definitely a part that was missing. We should rethink the way the logo and dividers are embedded, more about it in the comment section.
Member
Author
|
My work seems not to be good enough for you, so I’ve closed the PR. |
Member
I like the changes, so if that wasn't clear from the comment, I'm sorry. We can also take another look at the topics together if you'd like :) |
# Conflicts: # layouts/partials/header.html
MoritzWeber0
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've done some improvements for dark mode. Boxes and Cards now stand out more from the background. The logo and intersectors now react on color change.