Skip to content

Conversation

@therobrob
Copy link
Member

@therobrob therobrob commented Aug 31, 2025

Description

With svg use we don’t have to add them to DOM directly, but can change the color in dark mode.

@therobrob therobrob added the technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc. label Aug 31, 2025
@netlify
Copy link

netlify bot commented Aug 31, 2025

Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit 03c7923
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/68b703311ef5e900088e8d07
😎 Deploy Preview https://deploy-preview-297--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@therobrob therobrob changed the title changed logo to svg use SVGs: Use of <use> Aug 31, 2025
@therobrob therobrob marked this pull request as ready for review August 31, 2025 16:26
@therobrob therobrob requested a review from MoritzWeber0 August 31, 2025 16:27
MoritzWeber0
MoritzWeber0 previously approved these changes Sep 1, 2025
Copy link
Member

@MoritzWeber0 MoritzWeber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool improvement, didn't know about the use-tag before and learned something new. Just two comments for my understanding, they should not block the merge.

@MoritzWeber0 MoritzWeber0 merged commit 4d7c968 into main Sep 2, 2025
7 checks passed
@MoritzWeber0 MoritzWeber0 deleted the fix/dark-mode-improvements-2 branch September 2, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants