Skip to content

Conversation

@MoritzWeber0
Copy link
Member

List countries without FIP acceptance, show them on the map & add a glossary to the map.

Resolves #290

@netlify
Copy link

netlify bot commented Sep 9, 2025

Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit 3e23609
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/68c1ead89730dc0008df0355
😎 Deploy Preview https://deploy-preview-303--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@MoritzWeber0 MoritzWeber0 requested a review from Copilot September 9, 2025 20:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to display countries without FIP acceptance on the country overview page, including a visual representation on the interactive map with a legend to distinguish different country statuses.

  • Adds a new section listing countries without FIP acceptance alongside the existing country overview
  • Implements map legend showing three states: available (FIP guide available), pending (content not available yet), and unavailable (no FIP acceptance)
  • Updates styling for better visual organization and accessibility of the country listings

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
layouts/country/list.html Adds countries without FIP section, map legend, and hardcoded unavailable countries list
i18n/fr.yaml, i18n/en.yaml, i18n/de.yaml Adds translations for new UI elements including legend and countries without FIP labels
content/country/_index.*.md Adds frontmatter configuration for countries without FIP acceptance in each language
assets/sass/styles.scss Updates list styling for better visual presentation
assets/sass/interactiveMap.scss Adds styling for unavailable countries and map legend
assets/js/interactiveMap.js Implements logic to mark unavailable countries on the interactive map

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@MoritzWeber0 MoritzWeber0 force-pushed the feat/no-fip-acceptance branch 2 times, most recently from 9181e8b to 3cf7dd7 Compare September 9, 2025 20:19
lenderom
lenderom previously approved these changes Sep 9, 2025
@therobrob
Copy link
Member

therobrob commented Sep 10, 2025

Thanks! I'll take another look at the code later. First, a question: Do San Marino, Andorra, Monaco, and Cyprus accept FIP or should we mark them as well? :)

@MoritzWeber0
Copy link
Member Author

MoritzWeber0 commented Sep 10, 2025

Thanks! I'll take another look at the code later. First, a question: Do San Marino, Andorra, Monaco, and Cyprus accept FIP or should we mark them as well? :)

San Marino, Andorra and Cyprus have no railway as far as I know, so I can add them to the list. Maybe it's worth to have another list of countries without railway at all? In Monaco, trains are operated by SNCF, not sure how the acceptance is.

I'll also add Moldova & Belarus to the list.

EDIT: Done.

@therobrob
Copy link
Member

therobrob commented Sep 10, 2025

Thanks! I'll take another look at the code later. First, a question: Do San Marino, Andorra, Monaco, and Cyprus accept FIP or should we mark them as well? :)

San Marino, Andorra and Cyprus have no railway as far as I know, so I can add them to the list. Maybe it's worth to have another list of countries without railway at all? In Monaco, trains are operated by SNCF, not sure how the acceptance is.

I'll also add Moldova & Belarus to the list.

Thank you! :) I've added Monaco to the sncf entry in our content status list.

Furthermore i've made some smaller structural changes:

  • changed country-list to a semantic <ul>
  • added aria-labelledby to the lists & map for accessibility
  • harmonized the wording of the headlines

Hopefully this makes sense for you :) If not, please let me know :)

@MoritzWeber0
Copy link
Member Author

Thanks! I'll take another look at the code later. First, a question: Do San Marino, Andorra, Monaco, and Cyprus accept FIP or should we mark them as well? :)

San Marino, Andorra and Cyprus have no railway as far as I know, so I can add them to the list. Maybe it's worth to have another list of countries without railway at all? In Monaco, trains are operated by SNCF, not sure how the acceptance is.
I'll also add Moldova & Belarus to the list.

Thank you! :) I've added Monaco to the sncf entry in our content status list.

Furthermore i've made some smaller structural changes:

  • changed country-list to a semantic <ul>
  • added aria-labelledby to the lists & map for accessibility
  • harmonized the wording of the headlines

Hopefully this makes sense for you :) If not, please let me know :)

Thanks for the improvements, looks good to me :)

@lenderom lenderom merged commit 5ac3122 into main Sep 12, 2025
7 checks passed
@lenderom lenderom deleted the feat/no-fip-acceptance branch September 12, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Country Map

4 participants