-
-
Notifications
You must be signed in to change notification settings - Fork 17
feat: List countries without FIP acceptance #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds functionality to display countries without FIP acceptance on the country overview page, including a visual representation on the interactive map with a legend to distinguish different country statuses.
- Adds a new section listing countries without FIP acceptance alongside the existing country overview
- Implements map legend showing three states: available (FIP guide available), pending (content not available yet), and unavailable (no FIP acceptance)
- Updates styling for better visual organization and accessibility of the country listings
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| layouts/country/list.html | Adds countries without FIP section, map legend, and hardcoded unavailable countries list |
| i18n/fr.yaml, i18n/en.yaml, i18n/de.yaml | Adds translations for new UI elements including legend and countries without FIP labels |
| content/country/_index.*.md | Adds frontmatter configuration for countries without FIP acceptance in each language |
| assets/sass/styles.scss | Updates list styling for better visual presentation |
| assets/sass/interactiveMap.scss | Adds styling for unavailable countries and map legend |
| assets/js/interactiveMap.js | Implements logic to mark unavailable countries on the interactive map |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
9181e8b to
3cf7dd7
Compare
|
Thanks! I'll take another look at the code later. First, a question: Do San Marino, Andorra, Monaco, and Cyprus accept FIP or should we mark them as well? :) |
San Marino, Andorra and Cyprus have no railway as far as I know, so I can add them to the list. Maybe it's worth to have another list of countries without railway at all? In Monaco, trains are operated by SNCF, not sure how the acceptance is. I'll also add Moldova & Belarus to the list. EDIT: Done. |
0c675d6 to
78edd4e
Compare
Thank you! :) I've added Monaco to the sncf entry in our content status list. Furthermore i've made some smaller structural changes:
Hopefully this makes sense for you :) If not, please let me know :) |
Thanks for the improvements, looks good to me :) |
List countries without FIP acceptance, show them on the map & add a glossary to the map.
Resolves #290