-
-
Notifications
You must be signed in to change notification settings - Fork 19
feat: Add operators to navbar & merge dropdown implementations #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
e6c741f to
ae206fa
Compare
ae206fa to
9d0c110
Compare
|
Could you check the mobile navigation? I think it looks a bit bugged. Maybe we don't need the border in the mobile navigation. :) But the Desktop Version is amazing 🤩 |
I'm not 100% happy with the mobile navigation either, but without borders is also not optimal (It's hard to recognize where the options belong to without the border). Maybe we can try a few options and have a look at it together. |
0232769 to
c41d049
Compare
therobrob
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've identifies just two little aspects:
- When the mobile menu is open, only the elements within the menu should be focusable. We implemented this on deutschebahn.com, but unfortunately I can't remember exactly how we did it. :'D
- ESC-Support for mobile menu
We can outsource it into a new issue, if you like :)



Resolves #292