Skip to content

Conversation

@MoritzWeber0
Copy link
Member

@MoritzWeber0 MoritzWeber0 commented Sep 11, 2025

Resolves #292

@netlify
Copy link

netlify bot commented Sep 11, 2025

Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit 4522cc3
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/68dab57e5a8dc80008a4b84c
😎 Deploy Preview https://deploy-preview-309--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@MoritzWeber0 MoritzWeber0 force-pushed the feat/reorder-navbar branch 3 times, most recently from e6c741f to ae206fa Compare September 20, 2025 12:28
@MoritzWeber0 MoritzWeber0 marked this pull request as ready for review September 20, 2025 12:28
@MoritzWeber0 MoritzWeber0 changed the title refactor: Reorder navigation bar; merge dropdown implementations feat: Add operators to navbar & merge dropdown implementations Sep 20, 2025
@lenderom
Copy link
Member

Could you check the mobile navigation? I think it looks a bit bugged. Maybe we don't need the border in the mobile navigation. :)

But the Desktop Version is amazing 🤩

@MoritzWeber0
Copy link
Member Author

MoritzWeber0 commented Sep 20, 2025

Could you check the mobile navigation? I think it looks a bit bugged. Maybe we don't need the border in the mobile navigation. :)

But the Desktop Version is amazing 🤩

I'm not 100% happy with the mobile navigation either, but without borders is also not optimal (It's hard to recognize where the options belong to without the border). Maybe we can try a few options and have a look at it together.

@MoritzWeber0
Copy link
Member Author

MoritzWeber0 commented Sep 25, 2025

Option 1 Option 2 Option 3
image image image

Copy link
Member

@therobrob therobrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've identifies just two little aspects:

  • When the mobile menu is open, only the elements within the menu should be focusable. We implemented this on deutschebahn.com, but unfortunately I can't remember exactly how we did it. :'D
  • ESC-Support for mobile menu

We can outsource it into a new issue, if you like :)

@MoritzWeber0 MoritzWeber0 merged commit 79ca44c into main Sep 29, 2025
7 checks passed
@MoritzWeber0 MoritzWeber0 deleted the feat/reorder-navbar branch September 29, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rearrange the navigation bar

4 participants