feat: Mobile content-navigation-menu #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # assets/js/main.js
# Conflicts: # assets/js/aside.js
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
therobrob
changed the title
# Conflicts: # assets/js/highlightHeadline.js # i18n/fr.yaml
Member
Author
|
Changes:
|
Instead, display the country/operator name Replace the button with a drag indicator
Instead, display the country/operator name Replace the button with a drag indicator
# Conflicts: # assets/js/resizeObserver.js # layouts/_default/baseof.html
therobrob
commented
Oct 9, 2025
therobrob
commented
Oct 9, 2025
MoritzWeber0
previously approved these changes
Oct 10, 2025
Member
There was a problem hiding this comment.
From my side, everything looks good now. Feel free to test my modifications on iOS and report any errors. Cool feature and nice implementation, thanks @therobrob 🥇
MoritzWeber0
previously approved these changes
Oct 10, 2025
Member
Author
|
There is one problem left: the max-height is calculated wrong, probably because safe-area-inset-bottom. I have a try to fix it! |
Member
Author
|
Thank you @MoritzWeber0 for code review and your optimizations <3 |
Member
🍾🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Display a content-navigation-menu on mobile devices (max. MD).