Skip to content

fix: Improve print view styling #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
therobrob merged 9 commits into from
Oct 6, 2025
Merged

fix: Improve print view styling #351

therobrob merged 9 commits into from
Oct 6, 2025

Conversation

@therobrob
Copy link
Member

@therobrob therobrob commented Oct 5, 2025 •
edited
Loading

I've added some styling improvements for print view.
@MoritzWeber0 i wasn't sure which unnecessary margins do you mean. It would be nice, if you could add some more information. :) What was the additional margin of the body-element intended for? I removed it for the moment.

Feel free to add some more improvements! :)

@therobrob therobrob linked an issue Oct 5, 2025 that may be closed by this pull request
Print version needs some optimization #305
Closed
@github-actions
Copy link

github-actions bot commented Oct 5, 2025 •
edited by therobrob
Loading

Hi there! 👋

Thank you for your contribution to the FIP Guide! 🚀
We appreciate your effort in making rail staff travel information more accessible. 🚄

Checklist before merging:

  • Added a description to the Pull Request
  • Checked the License of new pictures (non-commercial use without attribution)
  • Modified content in English
  • Modified content in German
  • Modified content in French

@netlify
Copy link

netlify bot commented Oct 5, 2025 •
edited
Loading

✅ Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit 030ff53
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/68e428df637b890009634088
😎 Deploy Preview https://deploy-preview-351--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@therobrob therobrob requested a review from MoritzWeber0 October 5, 2025 21:38
@therobrob therobrob changed the title print view styling Improve print view styling Oct 5, 2025
@MoritzWeber0 MoritzWeber0 changed the title Improve print view styling fix: Improve print view styling Oct 6, 2025
MoritzWeber0
MoritzWeber0 previously approved these changes Oct 6, 2025
View reviewed changes
Copy link
Member

@MoritzWeber0 MoritzWeber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @therobrob! The print page looks good again :)

I moved the @media print controls into the different classes, similar to the breakpoints media controls. This should make it easier in the future to keep them up-to-date when changing the CSS.

In addition, I removed some margins. Margins are handled already by the printing dialog of the browsers.

@therobrob
Copy link
Member Author

therobrob commented Oct 6, 2025

Thanks @MoritzWeber0, the decreased font-size looks good for me :)
If you're fine with the code, i would merge it with bypass rule, because i'm the initial author and you the last pusher :D

@MoritzWeber0
Copy link
Member

MoritzWeber0 commented Oct 6, 2025

Thanks @MoritzWeber0, the decreased font-size looks good for me :) If you're fine with the code, i would merge it with bypass rule, because i'm the initial author and you the last pusher :D

Sounds good. I just added another commit because I spotted a bug with the colors of the country map glossary, but now the PR should be ready to be merged :)

@therobrob therobrob merged commit 985581d into main Oct 6, 2025
7 checks passed
@therobrob therobrob deleted the 305-print-version-needs-some-optimization branch October 6, 2025 20:41
@MoritzWeber0 MoritzWeber0 mentioned this pull request Oct 6, 2025
Merged
therobrob added a commit that referenced this pull request Oct 6, 2025
@MoritzWeber0 @therobrob
fix: Improve list formatting in print view of country overview (#354)
7d23caa 
One additional commit for #351 to improve the list formatting that I
broke in the restructuring:

<img width="482" height="237" alt="image"
src="https://github.com/user-attachments/assets/e9031d3a-79dd-4ebb-a91d-21a3ce13f709"
/>

Co-authored-by: Robert Schuster <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoritzWeber0 MoritzWeber0 MoritzWeber0 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Print version needs some optimization

3 participants

@therobrob @MoritzWeber0