Skip to content

Conversation

@MoritzWeber0
Copy link
Member

@MoritzWeber0 MoritzWeber0 commented Oct 7, 2025

In booking providers, each section has it's own paragraph. The CSS rule removed the margin for these paragraphs as it was the last element in relation to the parent.

This leads to missing margins, here in the example between the text and the Reservations heading:
image

After the change:
image

@MoritzWeber0 MoritzWeber0 requested a review from therobrob October 7, 2025 20:24
@netlify
Copy link

netlify bot commented Oct 7, 2025

Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit b7410cd
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/68e7bc1508943e00077d18f0
😎 Deploy Preview https://deploy-preview-367--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Hi there! 👋

Thank you for your contribution to the FIP Guide! 🚀
We appreciate your effort in making rail staff travel information more accessible. 🚄

Checklist before merging:

  • Added a description to the Pull Request
  • Checked the License of new pictures (non-commercial use without attribution)
  • Modified content in English
  • Modified content in German
  • Modified content in French

@MoritzWeber0 MoritzWeber0 added the technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc. label Oct 7, 2025
@therobrob
Copy link
Member

The css-rule is for the last paragraph in the article, because otherwise there is too much space and it doesn't look consistent. Maybe you could adjust the rule so that it doesn't affect the (booking) expanders? :)
Bildschirmfoto 2025-10-07 um 22 39 55

@MoritzWeber0
Copy link
Member Author

The css-rule is for the last paragraph in the article, because otherwise there is too much space and it doesn't look consistent. Maybe you could adjust the rule so that it doesn't affect the (booking) expanders? :)

I modified the rule, feel free to have another look.

@therobrob
Copy link
Member

thanks :) i've added some more relevant cases, please have a look, if you agree :)

@MoritzWeber0
Copy link
Member Author

thanks :) i've added some more relevant cases, please have a look, if you agree :)

The improvements look good. In addition, I removed the margins from all p elements in the sources, otherwise there is a lot of space between the list elements.

@MoritzWeber0 MoritzWeber0 merged commit 8dda47b into main Oct 9, 2025
4 of 7 checks passed
@MoritzWeber0 MoritzWeber0 deleted the fix/missing-margin branch October 9, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants