Skip to content

Conversation

@MoritzWeber0
Copy link
Member

Resolves #362

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Hi there! 👋

Thank you for your contribution to the FIP Guide! 🚀
We appreciate your effort in making rail staff travel information more accessible. 🚄

Checklist before merging:

  • Added a description to the Pull Request
  • Checked the License of new pictures (non-commercial use without attribution)
  • Modified content in English
  • Modified content in German
  • Modified content in French

@netlify
Copy link

netlify bot commented Oct 7, 2025

Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit 244c593
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/68e6b8429944bc00086a41f8
😎 Deploy Preview https://deploy-preview-369--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@MoritzWeber0 MoritzWeber0 added the technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc. label Oct 7, 2025
@lenderom
Copy link
Member

lenderom commented Oct 8, 2025

Why is this here a H4 and in all other booking sites we use a H2?

@MoritzWeber0
Copy link
Member Author

MoritzWeber0 commented Oct 8, 2025

Why is this here a H4 and in all other booking sites we use a H2?

For booking platforms, H2 is correct to match the structure of the headings tree. The headings are directly below the main title of booking platform. When they are embedded in the operator pages, they should fit to the structure of the page; the H2 elements are transformed to H4. This transformation doesn't happen for the headings directly defined as content of the booking expander on the operator page, only the rendered content is transformed.

@therobrob therobrob merged commit 2577e82 into main Oct 8, 2025
7 checks passed
@therobrob therobrob deleted the fix/divider-ns-ticket-office branch October 8, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Divider in NS Booking on Eurostar page (German version only)

4 participants