Skip to content

feat: Make search usable from all pages #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
therobrob merged 32 commits into from
Oct 15, 2025
Merged

feat: Make search usable from all pages #391

therobrob merged 32 commits into from
Oct 15, 2025

Conversation

@therobrob
Copy link
Member

@therobrob therobrob commented Oct 11, 2025 •
edited
Loading

  • added search for all pages
  • refactored search implementation
  • refactored overlay implementation
  • structure changes in i11n

@therobrob therobrob linked an issue Oct 11, 2025 that may be closed by this pull request
Make Search usable from all pages #120
Closed
@netlify
Copy link

netlify bot commented Oct 11, 2025 •
edited
Loading

✅ Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit 41a8e1f
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/68ef44774f37060008b14b57
😎 Deploy Preview https://deploy-preview-391--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Oct 11, 2025 •
edited by therobrob
Loading

Hi there! 👋

Thank you for your contribution to the FIP Guide! 🚀
We appreciate your effort in making rail staff travel information more accessible. 🚄

Checklist before merging:

  • Added a description to the Pull Request
  • Checked the License of new pictures (non-commercial use without attribution)
  • Modified content in English
  • Modified content in German
  • Modified content in French

@therobrob therobrob marked this pull request as ready for review October 12, 2025 09:39
@MoritzWeber0 MoritzWeber0 mentioned this pull request Oct 12, 2025
Merged
@therobrob therobrob added the enhancement New feature or request label Oct 12, 2025
@MoritzWeber0 MoritzWeber0 changed the title Make search usable from all pages feat: Make search usable from all pages Oct 14, 2025
MoritzWeber0
MoritzWeber0 reviewed Oct 14, 2025
View reviewed changes
@MoritzWeber0
Copy link
Member

MoritzWeber0 commented Oct 14, 2025 •
edited
Loading

Thanks for the cleanup of the overlay implementations and also the translation files. I modified some parts, mainly related to styling. The most significant change is that I added the !important flag to the --pagefind-ui-scale, which changes the scale of the search. It wasn't considered before.

Just this comment requires additional action or discussion, otherwise the PR is ready to be merged.

Before:
image

After:
image

@therobrob
Copy link
Member Author

therobrob commented Oct 15, 2025

thanks Moritz for reviewing and the styling update! i'm going to have a look!

@therobrob therobrob merged commit 1e2c19c into main Oct 15, 2025
7 checks passed
@therobrob therobrob deleted the 120-make-search-usable-from-all-pages branch October 15, 2025 06:55
@MoritzWeber0 MoritzWeber0 mentioned this pull request Oct 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoritzWeber0 MoritzWeber0 MoritzWeber0 left review comments

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make Search usable from all pages

4 participants

@therobrob @MoritzWeber0 @lenderom