Skip to content

feat: Report issues on pages directly from sidemenu #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lenderom merged 1 commit into from
May 7, 2025
Merged

feat: Report issues on pages directly from sidemenu #97

lenderom merged 1 commit into from
May 7, 2025

Conversation

@MoritzWeber0
Copy link
Member

@MoritzWeber0 MoritzWeber0 commented May 3, 2025

Description

Add a link to report issues directly in the sidemenu. Corresponding labels are auto-added to the report.

Depends on #96. Do not merge before #96 is merged!

The content was modified in the following languages:

  • English
  • German

@MoritzWeber0 MoritzWeber0 added content Improvements or additions to the content (countries, news, operators, general content) technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc. labels May 3, 2025
@MoritzWeber0 MoritzWeber0 requested a review from lenderom May 3, 2025 13:28
@MoritzWeber0 MoritzWeber0 marked this pull request as draft May 3, 2025 18:25
@MoritzWeber0 MoritzWeber0 removed the content Improvements or additions to the content (countries, news, operators, general content) label May 3, 2025
@lenderom
Copy link
Member

lenderom commented May 5, 2025

Rework text label and add external link symbol

@MoritzWeber0 MoritzWeber0 force-pushed the use-fontsource branch 3 times, most recently from 40d51c2 to 91c90cd Compare May 5, 2025 19:32
Base automatically changed from use-fontsource to main May 6, 2025 07:15
@MoritzWeber0 MoritzWeber0 marked this pull request as ready for review May 6, 2025 21:58
@netlify
Copy link

netlify bot commented May 6, 2025 •
edited
Loading

✅ Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit 9d6daa5
🔍 Latest deploy log https://app.netlify.com/sites/fipguide/deploys/681a86805fd722000879d04c
😎 Deploy Preview https://deploy-preview-97--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MoritzWeber0 MoritzWeber0 linked an issue May 6, 2025 that may be closed by this pull request
Underline of links slightly broken #116
Closed
@MoritzWeber0
Copy link
Member Author

MoritzWeber0 commented May 6, 2025

Rework text label and add external link symbol

Done

@MoritzWeber0
Copy link
Member Author

MoritzWeber0 commented May 6, 2025

Also added two minor fixes to the PR:

  • Links are rendered properly again (there was a trailing whitespace after the icon before)
  • The page doesn't "jump" anymore when loading initially since icons have fixed size now and are hidden until the font is loaded (before the text representation was displayed during loading).

@lenderom lenderom merged commit 25bcaf5 into main May 7, 2025
7 checks passed
@lenderom lenderom deleted the report-issue branch May 7, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lenderom lenderom lenderom approved these changes

Assignees

No one assigned

Labels

technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Underline of links slightly broken

3 participants

@MoritzWeber0 @lenderom