docs(kits): remove stale factory-pattern references - #2930
Open
cabljac wants to merge 1 commit into
Open
Conversation
The define-factory tier was dropped; index.ts now wires triggers directly with param expressions. Update the incremental-capture stub comment and translate-text SPEC to match.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates documentation and code comments in the firestore-incremental-capture and firestore-translate-text packages to clarify trigger wiring details and how secrets are passed to trigger options. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The define-factory tier was dropped from the kits pattern; the reference package (firestore-bigquery-export) now wires triggers directly at module top level with deploy-time param expressions.
Two docs still described the old shape:
Both updated to describe the current pattern (direct trigger wiring, secrets via the trigger's secrets option).