Skip to content

[Crashlytics] Internal logging gating.#8114

Open
OOS93 wants to merge 2 commits intomainfrom
OOS93/crashlytics_logger_gate
Open

[Crashlytics] Internal logging gating.#8114
OOS93 wants to merge 2 commits intomainfrom
OOS93/crashlytics_logger_gate

Conversation

@OOS93
Copy link
Copy Markdown
Collaborator

@OOS93 OOS93 commented May 8, 2026

Resolves: #2973

Context
Crashlytics internal logging currently has no implementation to turn off all log events (within code scope).

Default configuration allows the following events to be printed:

Captura de pantalla 2026-05-07 a la(s) 8 46 21 p m

Proposed Solution
Adding a resource bool flag, which is consumed at init stage and set to Logger as an additional control for log events (if enabled, previous logic will be executed).

Alternatives

  • Instead of using resources, adding a meta data definition at Crashlytics manifest so this flag can be consumed the same way as FirePerf does (link for reference: https://github.com/firebase/firebase-android-sdk/blob/main/firebase-perf/src/main/java/com/google/firebase/perf/util/Utils.java#L98).
    Keep an eye: This approach consumes resources (which can hinder start up process) just to gate the log cat events (which is not Crashlytics priority).

  • Instead of consuming a resources flag, simply just aim for BuildConfig.DEBUG.

  • For release, use ProGuard rules to strip log interactions.

  • For debug sessions, disable log cat using adb shell setprop log.tag.FirebaseCrashlytics SUPPRESS.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

This provides the flexibility to update the flag dynamically from the client side, replacing the static compile-time BuildConfig constant.
@google-oss-bot
Copy link
Copy Markdown
Collaborator

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@OOS93 OOS93 requested a review from mrober May 8, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants