dataconnect(chore): DataConnectGrpcRPCs.kt: fix wasteful conversion to Struct only used for debug logging

[dconeybe]

This PR optimizes the gRPC logging in DataConnectGrpcRPCs.kt by deferring the conversion of request and response objects to Struct protos until they are actually needed for debug logging.

Highlights

• Deferred Logging Payloads: Refactored logGrpcSending and logGrpcReceived to accept lambdas instead of pre-computed Struct objects, preventing unnecessary computation when debug logging is disabled.
• Inline Logging Functions: Marked logging helper functions as inline to allow the use of lambda parameters without additional allocation overhead.

Changelog

Modified files

• CHANGELOG.md: Added an entry for the optimization of debug logging computation.
• DataConnectGrpcRPCs.kt: Refactored gRPC logging to use inline functions with deferred payload evaluation.

[gemini-code-assist]

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

[dconeybe]

/gemini review

[gemini-code-assist]

Code Review

This pull request optimizes debug logging in DataConnectGrpcRPCs.kt by implementing lazy evaluation for gRPC request and response serialization. By updating logGrpcSending and logGrpcReceived to accept lambdas and marking them as inline, the potentially expensive toStructProto() calls are only executed when debug logging is active. Feedback was provided to replace a placeholder PR number in the CHANGELOG.md file.

[github-actions]

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.