Skip to content

dataconnect(chore): DataConnectGrpcRPCs.kt: take connectorResourceName as constructor parameter#8127

Open
dconeybe wants to merge 2 commits intomainfrom
dconeybe/dataconnect/DataConnectGrpcRPCsConnectorResourceNameConstructorParameter
Open

dataconnect(chore): DataConnectGrpcRPCs.kt: take connectorResourceName as constructor parameter#8127
dconeybe wants to merge 2 commits intomainfrom
dconeybe/dataconnect/DataConnectGrpcRPCsConnectorResourceNameConstructorParameter

Conversation

@dconeybe
Copy link
Copy Markdown
Contributor

@dconeybe dconeybe commented May 9, 2026

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@dconeybe
Copy link
Copy Markdown
Contributor Author

dconeybe commented May 9, 2026

/gemini review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@dconeybe dconeybe changed the title DataConnectGrpcRPCs.kt: take connectorResourceName as constructor parameter dataconnect(chore) DataConnectGrpcRPCs.kt: take connectorResourceName as constructor parameter May 9, 2026
@dconeybe dconeybe changed the title dataconnect(chore) DataConnectGrpcRPCs.kt: take connectorResourceName as constructor parameter dataconnect(chore): DataConnectGrpcRPCs.kt: take connectorResourceName as constructor parameter May 9, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the gRPC request construction logic by moving the responsibility of building ExecuteQueryRequest and ExecuteMutationRequest from DataConnectGrpcClient to DataConnectGrpcRPCs. As part of this change, connectorResourceName is now managed by DataConnectGrpcRPCs, and the execution methods have been updated to accept operationName and variables as individual parameters. Feedback was provided regarding the new OperationNameVariablesPair test utility class, suggesting it be converted to a data class to ensure that Kotest's distinct() and distinctPair() functions work correctly via value-based equality rather than identity.

…a class (as suggested by gemini) to make distinct() work properly
@dconeybe dconeybe marked this pull request as ready for review May 9, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant