Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
There was a problem hiding this comment.
Code Review
This pull request refactors the gRPC request construction logic by moving the responsibility of building ExecuteQueryRequest and ExecuteMutationRequest from DataConnectGrpcClient to DataConnectGrpcRPCs. As part of this change, connectorResourceName is now managed by DataConnectGrpcRPCs, and the execution methods have been updated to accept operationName and variables as individual parameters. Feedback was provided regarding the new OperationNameVariablesPair test utility class, suggesting it be converted to a data class to ensure that Kotest's distinct() and distinctPair() functions work correctly via value-based equality rather than identity.
…a class (as suggested by gemini) to make distinct() work properly
No description provided.