Skip to content

dataconnect(test): RandomSeedTestRule: add seeded constructor, and implementation cleanup#8130

Draft
dconeybe wants to merge 4 commits intomainfrom
dconeybe/dataconnect/RandomSeedTestRuleSeededConstructorAdded
Draft

dataconnect(test): RandomSeedTestRule: add seeded constructor, and implementation cleanup#8130
dconeybe wants to merge 4 commits intomainfrom
dconeybe/dataconnect/RandomSeedTestRuleSeededConstructorAdded

Conversation

@dconeybe
Copy link
Copy Markdown
Contributor

@dconeybe dconeybe commented May 9, 2026

This PR adds a seeded constructor to RandomSeedTestRule to allow replaying tests with a specific seed and cleans up the rule's implementation.

Highlights

  • Seeded Constructor: Added a new constructor to RandomSeedTestRule that accepts a Long seed, facilitating the reproduction of test failures that depend on a specific random sequence.
  • Implementation Cleanup: Refactored the evaluate() method from runCatching to a try-catch block to improve readability and control flow.
  • Exception Handling: Updated the failure logging to ignore AssumptionViolatedException, ensuring that skipped tests do not trigger the "test failed" warning message.
  • Output Stream: Changed failure log output from System.out to System.err for better visibility in test logs.
  • Documentation: Added KDoc documentation for the class property and its various constructors.

Changelog

1 file changed
  • RandomSeedTestRule.kt: Added a seeded constructor, documented the rs property and constructors, and refactored the evaluation logic to use try-catch while specifically handling AssumptionViolatedException.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant