Chore: update CI to run on Node 24, drop Node 18 and 20 from CI, maintain Node 20 engine support#1901
Chore: update CI to run on Node 24, drop Node 18 and 20 from CI, maintain Node 20 engine support#1901ajperel wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the minimum required Node.js version in package.json from >=18.0.0 to >=20.0.0. The feedback points out that the integration test script (integration_test/run_tests.sh) still runs tests on obsolete Node.js versions 14 and 16, and recommends updating them to supported versions like 20 and 22 to ensure compatibility.
| }, | ||
| "engines": { | ||
| "node": ">=18.0.0" | ||
| "node": ">=20.0.0" |
There was a problem hiding this comment.
With the minimum Node.js version bumped to >=20.0.0, the integration tests in integration_test/run_tests.sh (line 95) are still configured to run on obsolete Node.js versions 14 and 16. Please update the integration test script to test supported Node.js runtimes (e.g., 20 and 22) to ensure compatibility and prevent installation or runtime failures during testing.
…tain Node 20 engine support
ajperel
force-pushed
the
ajp/upgrade-node-24
branch
from
89c163f to
5a752f4
Compare
3 participants
Our CI is dropping support for Node 20 imminently so updating ahead of that.
Given that Node 18 runtime in decommissioned for Google Cloud Functions updating our supported runtime to 20.