New command that allows for a user to run mobile tests that are defined as yaml. #9626

jrothfeder · 2025-12-16T17:40:05Z

Description

New command that allows for a user to run mobile tests that are defined as yaml. Tests will be read from a test dir and run remotely. Filters can be supplied to specify which tests are run.

Scenarios Tested

Tested running mobile tests from the command line.

Sample Commands

firebase apptesting:mobile-execute --app=1:359214138129:android:423758dfdb494e05f002b0 --test-dir=mytests ./app/build/outputs/apk/alpha/debug/app-alpha-debug.apk

gemini-code-assist · 2025-12-16T17:40:22Z

Summary of Changes

Hello @jrothfeder, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the initial infrastructure for an experimental Mobile App Testing Agent (MATA) feature. It modifies the test parsing logic to make target URIs optional, accommodating diverse testing scenarios, potentially including those for mobile applications. Additionally, it enhances the logging within the test file parsing utility to provide clearer insights into its operation.

Highlights

Experimental MATA Feature: Introduced a new public experiment named 'mata' which stands for Mobile App Testing Agent, laying the groundwork for mobile app testing capabilities.
New Mobile App Testing Command: Added a new command, 'apptesting-mobile-execute', which becomes available when the 'mata' experiment is enabled, indicating a dedicated entry point for mobile test execution.
Flexible Test URI Handling: The 'targetUri' parameter in 'parseTestFiles' and the 'startUri' property in the 'TestCase' interface have been made optional, allowing for test configurations that may not always require a specific URI.
Enhanced Test File Parsing Logging: Improved visibility into the test file parsing process by adding logger statements to track file reading, parsing, and the number of tests found.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new experimental feature, "mata", for mobile app testing. The changes make targetUri optional when parsing test files to support this new feature. While the changes are mostly correct, there are a few critical issues that need to be addressed. A logging statement in parseTestFiles.ts incorrectly logs entire file contents, which is a security and performance concern. There's also a potential null reference exception in src/commands/index.ts when initializing the new mata command. Additionally, there are some opportunities to improve type safety and logging verbosity.

src/apptesting/parseTestFiles.ts

src/commands/index.ts

src/apptesting/parseTestFiles.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

src/experiments.ts

…ting apptesting experiment.

src/commands/apptesting-mobile-execute.ts

* Add support for prerequisite tests * Address GCA comments

kaibolay · 2026-01-05T16:32:34Z

src/commands/apptesting-mobile-execute.ts

+  },
+];
+
+export const command = new Command("apptesting:mobile-execute <target>")


Having a dash in the command is out-of-style for the firebase CLI.

So this could be apptesting:mobile:execute, but that'd be weird. I think just extending the existing apptesting:execute makes much more sense (mobile vs. web can be determined by looking at the app ID).

Or the app distribution namespace...

kaibolay · 2026-01-05T16:39:37Z

src/apptesting/parseTestFiles.spec.ts

+          tests: [
+            {
+              id: "my-first-test",
+              testName: "my first test",


Shouldn't this be displayName? Why does this work?

WATA uses testName. This initially tripped me up as well, so maybe we need to chat some more about this.

kaibolay · 2026-01-05T16:43:54Z

src/apptesting/parseTestFiles.spec.ts

+            {
+              id: "my-first-test",
+              testName: "my first test",
+              steps: [{ goal: "do something first" }],


I'm confused: In other tests in this file I see the steps under instructions. Is both supported?

The problem is that we want to be compatible with the format produced by appdistribution:testcases:export and the existing web test configuration. I think we need some better test coverage for that.

So we need to be compatible with the WATA file format and the format produced by appdistribution:testcases:export? I wonder if we can just decide on one particular format instead...

This keeps coming up but there's no requirement that we are compatible with appdistribution:export. Being compatible with wata makes sense here and also allows us to reuse the testcase loading code.

WIP

7b9e146

WIP

ae07bd4

gemini-code-assist bot reviewed Dec 16, 2025

View reviewed changes

src/apptesting/parseTestFiles.ts Outdated Show resolved Hide resolved

src/commands/index.ts Outdated Show resolved Hide resolved

src/apptesting/parseTestFiles.ts Outdated Show resolved Hide resolved

src/apptesting/parseTestFiles.ts Outdated Show resolved Hide resolved

WIP

fb8b5ae

jrothfeder changed the title ~~WIP~~ New command that allows for a user to run mobile tests that are defined as yaml. Dec 16, 2025

jrothfeder and others added 2 commits December 16, 2025 13:57

Update src/apptesting/parseTestFiles.ts

efbdf28

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Apply suggestion from @gemini-code-assist[bot]

e5654a8

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

jrothfeder requested a review from tagboola December 16, 2025 19:03

Merge branch 'main' into test-schema

ad7d56d

jrothfeder requested review from kjelko and lfkellogg December 16, 2025 19:09

Jamie Rothfeder added 2 commits December 16, 2025 14:09

Remove accidently committed test directory.

1b7d6a4

Fix ordering of params.

ff27bfe

kjelko reviewed Dec 16, 2025

View reviewed changes

src/experiments.ts Outdated Show resolved Hide resolved

Jamie Rothfeder and others added 2 commits December 16, 2025 14:52

Remove MATA experiment and instead roll this functionality under exis…

87a08e6

…ting apptesting experiment.

Merge branch 'main' into test-schema

463ad1e

tagboola reviewed Dec 16, 2025

View reviewed changes

src/commands/apptesting-mobile-execute.ts Show resolved Hide resolved

jrothfeder and others added 5 commits December 17, 2025 09:36

Merge branch 'main' into test-schema

8ebaa0d

Merge branch 'main' into test-schema

d36742e

Add support to specify devices.

df382b6

Add support for prerequisite tests (#9651)

4b7de39

* Add support for prerequisite tests * Address GCA comments

Merge branch 'main' into test-schema

c7a866e

kaibolay reviewed Jan 5, 2026

View reviewed changes

Merge branch 'main' into test-schema

5a8d85a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

New command that allows for a user to run mobile tests that are defined as yaml. #9626

New command that allows for a user to run mobile tests that are defined as yaml. #9626

jrothfeder commented Dec 16, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Dec 16, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kaibolay Jan 5, 2026

Uh oh!

kaibolay Jan 5, 2026

Uh oh!

tagboola Jan 5, 2026

Uh oh!

kaibolay Jan 5, 2026

Uh oh!

tagboola Jan 5, 2026

Uh oh!

jrothfeder Jan 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

New command that allows for a user to run mobile tests that are defined as yaml. #9626

Are you sure you want to change the base?

New command that allows for a user to run mobile tests that are defined as yaml. #9626

Conversation

jrothfeder commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Scenarios Tested

Sample Commands

Uh oh!

gemini-code-assist bot commented Dec 16, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kaibolay Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

kaibolay Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

tagboola Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

kaibolay Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

tagboola Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

jrothfeder Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jrothfeder commented Dec 16, 2025 •

edited

Loading