Skip to content

Add limited use token to functions#1444

Open
AustinBenoit wants to merge 19 commits intomainfrom
LimitedUsedUnity
Open

Add limited use token to functions#1444
AustinBenoit wants to merge 19 commits intomainfrom
LimitedUsedUnity

Conversation

@AustinBenoit
Copy link
Copy Markdown
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Add limited use token to functions. Developers can now set http options to include limited use tokens


Testing

Describe how you've tested these changes.

Added new integration test.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Limited Use App Check tokens in Firebase Functions by updating the reflection-based interop layer and adding a new HttpsCallableOptions class. The changes also include updates to the test application and CI scripts to verify the new functionality. Feedback was provided concerning a potential breaking change in the reflection initialization logic that could disable App Check for older SDKs, along with a suggestion to improve an incomplete error message.

Comment thread app/src/internal/FirebaseInterops.cs
Comment thread app/src/internal/FirebaseInterops.cs Outdated
@AustinBenoit AustinBenoit added the tests-requested: quick Trigger a quick set of integration tests. label Apr 29, 2026
@github-actions github-actions Bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Apr 29, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 29, 2026

❌  Integration test FAILED

Requested by @firebase-workflow-trigger[bot] on commit be211d1
Last updated: Fri May 8 14:31 PDT 2026
View integration test log & download artifacts

Failures Configs
/Users/runner/work/firebase-unity-sdk/firebase-unity-sdk/testapps/firebaseai/MacOSTestapp/testapp.app/Contents/MacOS/Firebase AI Unity Testapp [TEST] [FAILURE] [2021] [1/2 Build OS(s): windows] [1/5 Platform(s): macOS] [1/2 Test Device(s): github_runner]
/home/runner/work/firebase-unity-sdk/firebase-unity-sdk/testapps/firebaseai/LinuxTestapp/testapp [TEST] [FAILURE] [2021] [1/2 Build OS(s): windows] [1/5 Platform(s): Linux] [1/2 Test Device(s): github_runner]
/home/runner/work/firebase-unity-sdk/firebase-unity-sdk/testapps/iOS/firebaseai/FirebaseAIUnityTestapp.ipa [TEST] [FAILURE] [2021] [1/2 Build OS(s): macos] [1/5 Platform(s): 14] [1/2 Test Device(s): iOS]
D:\a\firebase-unity-sdk\firebase-unity-sdk\testapps\Unity2021.3.43f1-NET4.6\FirebaseAI\testapp [TEST] [FAILURE] [2021] [1/2 Build OS(s): windows] [1/5 Platform(s): Playmode] [1/2 Test Device(s): github_runner]
D:\a\firebase-unity-sdk\firebase-unity-sdk\testapps\firebaseai\WindowsTestapp\testapp.exe [TEST] [FAILURE] [2021] [1/2 Build OS(s): windows] [1/5 Platform(s): Windows] [1/2 Test Device(s): github_runner]

@github-actions github-actions Bot added the tests: failed This PR's integration tests failed. label Apr 29, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 29, 2026
@AustinBenoit AustinBenoit added tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). and removed tests: failed This PR's integration tests failed. tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Apr 29, 2026
@github-actions github-actions Bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Apr 29, 2026
@AustinBenoit AustinBenoit added tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). and removed tests: in-progress This PR's integration tests are in progress. labels Apr 29, 2026
@github-actions github-actions Bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Apr 29, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 29, 2026
@AustinBenoit AustinBenoit added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. tests-requested: quick Trigger a quick set of integration tests. labels Apr 30, 2026
@AustinBenoit AustinBenoit added tests-requested: quick Trigger a quick set of integration tests. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 1, 2026
@AustinBenoit AustinBenoit added tests-requested: quick Trigger a quick set of integration tests. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 4, 2026
@AustinBenoit AustinBenoit added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels May 8, 2026
@AustinBenoit AustinBenoit added tests-requested: quick Trigger a quick set of integration tests. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 8, 2026
@github-actions github-actions Bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 8, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests: failed This PR's integration tests failed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants