fix(database,android): fix an issue where setPersistenceEnabled needed to be called first#18259
Conversation
…d to be called first
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
Description
Fixes an Android
firebase_databaseregression wheresetPersistenceEnabled()could crash withCalls to setPersistenceEnabled() must be made before any other usage of FirebaseDatabase instance.The Pigeon app settings already carry persistence and cache-size configuration to the native side. When a follow-up call such as
goOnline()applies those settings first, the original setter message can arrive later and re-apply the same native SDK setting after the database has been used. Android now skips that duplicate native setter call when the value was already present in the Pigeon settings object.An Android-only E2E regression test was added to cover calling
setPersistenceEnabled()immediately beforegoOnline()on fresh database instances.Related Issues
Checklist
///).melos run analyze) does not report any problems on my PR.Breaking Change