Skip to content

fix(database,android): fix an issue where setPersistenceEnabled needed to be called first#18259

Open
Lyokone wants to merge 1 commit intomainfrom
fix/18254
Open

fix(database,android): fix an issue where setPersistenceEnabled needed to be called first#18259
Lyokone wants to merge 1 commit intomainfrom
fix/18254

Conversation

@Lyokone
Copy link
Copy Markdown
Contributor

@Lyokone Lyokone commented May 6, 2026

Description

Fixes an Android firebase_database regression where setPersistenceEnabled() could crash with Calls to setPersistenceEnabled() must be made before any other usage of FirebaseDatabase instance.

The Pigeon app settings already carry persistence and cache-size configuration to the native side. When a follow-up call such as goOnline() applies those settings first, the original setter message can arrive later and re-apply the same native SDK setting after the database has been used. Android now skips that duplicate native setter call when the value was already present in the Pigeon settings object.

An Android-only E2E regression test was added to cover calling setPersistenceEnabled() immediately before goOnline() on fresh database instances.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[firebase_database]: android setPersistenceEnabled() must be made before any other usage

1 participant