Skip to content

[AI] Fix LiveViewModel compile against main#1853

Merged
andrewheard merged 1 commit intomainfrom
ah/live-view-model-fix
Apr 28, 2026
Merged

[AI] Fix LiveViewModel compile against main#1853
andrewheard merged 1 commit intomainfrom
ah/live-view-model-fix

Conversation

@andrewheard
Copy link
Copy Markdown
Contributor

Fixed the compilation issue introduced in firebase/firebase-ios-sdk#15904. This is a temporary fix since #1852 shouldn't be merged until Firebase 12.13 is released.

#no-changelog

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a temporary default case to a switch statement in LiveViewModel.swift to handle upcoming enum changes. The feedback suggests using @unknown default instead of a standard default case to ensure the compiler still generates warnings for unhandled cases, maintaining visibility of missing implementations while the temporary fix is in place.

@andrewheard andrewheard merged commit 3fb736d into main Apr 28, 2026
8 checks passed
@andrewheard andrewheard deleted the ah/live-view-model-fix branch April 28, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants