Conversation
bwinton
left a comment
bwinton
left a comment
There was a problem hiding this comment.
Couple of small things, but it generally looks good to me.
Let's see what @violasong thinks about the content of the, uh, content. 🙂
|
|
||
| Height: `8px` | ||
|
|
||
| Containing an `8px` x `5px` SVG |
There was a problem hiding this comment.
Can we link to one of the SVGs from the photon-icons site?
| ### Expand and collapse | ||
|
|
||
| <div class="grid-2" markdown="1"> | ||
|  |
There was a problem hiding this comment.
If you look at https://github.com/FirefoxUX/photon/pull/334/files#diff-80eddb616ebe9c94995bc02d10ea6519R30 you'll see that we recently added the ability to have a play/pause frame for animations, by adding the line: {:.animated} underneath, and providing files named pane-behaviour-play.png and pane-behaviour-pause.png. I think that might be something you want to take advantage of… 😉
violasong
left a comment
violasong
left a comment
There was a problem hiding this comment.
This looks good to me, and I'm glad to standardize on the Panes terminology.
3 participants
The first draft of the Pane documentation is ready for a second pair of eyes to read through!
@violasong @bwinton