feat: add Connection constructor and SqlDialect getter to AbstractSqlDialectHelper #815
+58
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dieppa
reviewed
Feb 2, 2026
Comment on lines
52
to
61
| if (dialectHelper.getSqlDialect() == SqlDialect.FIREBIRD) { | ||
| int errorCode = e.getErrorCode(); | ||
| String sqlState = e.getSQLState(); | ||
| String msg = e.getMessage() != null ? e.getMessage().toLowerCase() : ""; | ||
|
|
||
| if (errorCode == 335544351 || "42000".equals(sqlState) || msg.contains("already exists")) { | ||
| return; | ||
| } | ||
| if (errorCode == 335544351 || "42000".equals(sqlState) || msg.contains("already exists")) { | ||
| return; | ||
| } | ||
| throw new RuntimeException("Failed to initialize audit table", e); | ||
| } | ||
| throw new RuntimeException("Failed to initialize audit table", e); |
Member
There was a problem hiding this comment.
With the new refactored code, dialectHeleper can be null.
Suggested change
| if (dialectHelper.getSqlDialect() == SqlDialect.FIREBIRD) { | |
| int errorCode = e.getErrorCode(); | |
| String sqlState = e.getSQLState(); | |
| String msg = e.getMessage() != null ? e.getMessage().toLowerCase() : ""; | |
| if (errorCode == 335544351 || "42000".equals(sqlState) || msg.contains("already exists")) { | |
| return; | |
| } | |
| if (errorCode == 335544351 || "42000".equals(sqlState) || msg.contains("already exists")) { | |
| return; | |
| } | |
| throw new RuntimeException("Failed to initialize audit table", e); | |
| } | |
| throw new RuntimeException("Failed to initialize audit table", e); | |
| if (dialectHelper != null && dialectHelper.getSqlDialect() == SqlDialect.FIREBIRD) { | |
| int errorCode = e.getErrorCode(); | |
| String sqlState = e.getSQLState(); | |
| String msg = e.getMessage() != null ? e.getMessage().toLowerCase() : ""; | |
| if (errorCode == 335544351 || "42000".equals(sqlState) || msg.contains("already exists")) { | |
| return; | |
| } | |
| } | |
| throw new RuntimeException("Failed to initialize audit table", e); |
dieppa
requested changes
Feb 2, 2026
Member
dieppa
left a comment
dieppa
left a comment
There was a problem hiding this comment.
With the new refactored code, dialectHeleper can be null.
dieppa
requested changes
Feb 2, 2026
| } | ||
| } catch (SQLException e) { | ||
| // For Informix, ignore "Table or view already exists" error (SQLCODE -310) | ||
| if (dialectHelper.getSqlDialect() == SqlDialect.INFORMIX && |
Member
There was a problem hiding this comment.
the same here, dialectHelper may be null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.