Skip to content

nmod_poly_sqrt: throw error for non-prime modulus #2537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cxzhong wants to merge 1 commit into
base: main
Choose a base branch
from
Open

nmod_poly_sqrt: throw error for non-prime modulus #2537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/nmod_poly/invsqrt_series.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,21 @@
(at your option) any later version. See <https://www.gnu.org/licenses/>.
*/

#include "flint.h"
#include "ulong_extras.h"
#include "nmod_poly.h"
#include "gr_poly.h"

void
_nmod_poly_invsqrt_series(nn_ptr g, nn_srcptr h, slong hlen, slong n, nmod_t mod)
{
gr_ctx_t ctx;

/* Algorithm requires prime modulus */
if (!n_is_prime(mod.n))
flint_throw(FLINT_ERROR, "Exception (nmod_poly_invsqrt_series). "
"Modulus must be prime.\n");

_gr_ctx_init_nmod(ctx, &mod);
GR_MUST_SUCCEED(_gr_poly_rsqrt_series(g, h, hlen, n, ctx));
}
Expand Down
6 changes: 6 additions & 0 deletions src/nmod_poly/sqrt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
(at your option) any later version. See <https://www.gnu.org/licenses/>.
*/

#include "flint.h"
#include "ulong_extras.h"
#include "nmod_vec.h"
#include "nmod_poly.h"
Expand Down Expand Up @@ -39,6 +40,11 @@ _nmod_poly_sqrt(nn_ptr s, nn_srcptr p, slong len, nmod_t mod)
if (len % 2 == 0)
return len == 0;

/* Algorithm requires prime modulus */
if (!n_is_prime(mod.n))
flint_throw(FLINT_ERROR, "Exception (nmod_poly_sqrt). "
"Modulus must be prime.\n");

if (mod.n == 2)
return _nmod_poly_sqrt_2(s, p, len);

Expand Down
8 changes: 8 additions & 0 deletions src/nmod_poly/sqrt_series.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,21 @@
(at your option) any later version. See <https://www.gnu.org/licenses/>.
*/

#include "flint.h"
#include "ulong_extras.h"
#include "nmod_poly.h"
#include "gr_poly.h"

void
_nmod_poly_sqrt_series(nn_ptr g, nn_srcptr h, slong hlen, slong n, nmod_t mod)
{
gr_ctx_t ctx;

/* Algorithm requires prime modulus */
if (!n_is_prime(mod.n))
flint_throw(FLINT_ERROR, "Exception (nmod_poly_sqrt_series). "
"Modulus must be prime.\n");

_gr_ctx_init_nmod(ctx, &mod);
GR_MUST_SUCCEED(_gr_poly_sqrt_series(g, h, hlen, n, ctx));
}
Expand Down