Small pitch bend improvements #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add bend_scale setting (default 1.0) for adjusting pitch bend intensity - Fix compose_pitch_bend() overflow bug: max bend (16384) wrapped to min - Add helpful comments: LinnStrument Pitch Quantize must be OFF for smooth slides
zitongcharliedeng
force-pushed
the
pitch-bend-fixes
branch
from
afac787 to
af1a519
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small improvements that helped me:
bend_scalesetting for adjusting pitch bend intensity during MPE slidescompose_pitch_bend()where max bend wrapped to minEspecially useful for whole-tone horizontal slides - without smooth bends you can't reliably hit semitones in between the whole tones 1:1.