Add rumbleController API and Blockly block for gamepad haptics#346
Open
tracygardner wants to merge 7 commits intomainfrom
Open
Add rumbleController API and Blockly block for gamepad haptics#346tracygardner wants to merge 7 commits intomainfrom
rumbleController API and Blockly block for gamepad haptics#346tracygardner wants to merge 7 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
rumbleController(controller = "ANY", strength = 1, durationMs = 200)implementation inapi/xr.jsthat normalizes inputs, locates a matching gamepad, and usesvibrationActuatororhapticActuatorsto play effects or pulse, returningPromise<boolean>.rumbleControllerin the publicflockAPI and include it in the side-effect API list inflock.js.blocks/xr.js, a JS code generator ingenerators/generators.js, a toolbox entry intoolbox.js, and English localization/tooltip inlocale/en.js.API.mdwith parameters, return value, and an example.Testing
npm run build) and the test suite (npm test) after changes, and both completed successfully.npm run lint) was executed and showed no new errors related to these changes.Codex Task