Bugfix: Prevent mobile yank back - #741
Conversation
|
Warning Review limit reached
Next review available in: 31 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughWorkspace jump suppression now tracks canvas ChangesWorkspace jump suppression
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@main/blocklyinit.js`:
- Line 223: Update the conditional in the workspaceScroll flow that checks
fromFocusScroll, recentFieldInteraction, and largeHorizontalJump so it
suppresses only the horizontal scroll while preserving the requested Y
coordinate. Do not return early in a way that cancels both scroll coordinates;
ensure workspaceScroll(x, y) still applies the vertical target for focus
actions.
- Around line 211-223: Add a mobile/API regression test for the suppression
condition around lastCanvasPointerDown, fromFocusScroll, recentFieldInteraction,
and largeHorizontalJump. Simulate a canvas pointerdown followed by far-right
field focus/focus scrolling, assert horizontal scrolling is suppressed while
required vertical scrolling still occurs, then run the automated test suite and
report the result.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Summary
On mobile if a block is wide and you tried to open a dropdown on the far right of the block, the view would immediately be yanked back to the left side of the block before you could open it, meaning you couldn't use anything on the right of the blocks.
AI usage
Claude Sonnet 5 fixed this. I didn't participate much other than describing the problem.
Summary by CodeRabbit