Skip to content

Bugfix: Dont show eye in context bar if block disabled #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lawsie merged 1 commit into from
Aug 6, 2026
Merged

Bugfix: Dont show eye in context bar if block disabled #742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions ui/contextmenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,6 +1006,17 @@ export function initContextMenus(workspace) {
!!block.isMovable?.() &&
(!!block.previousConnection || !!block.outputConnection);

function scheduleViewMeshRecheck() {
clearTimeout(viewMeshRecheckTimer);
const recheckBlock = toolbarBlock;
viewMeshRecheckTimer = setTimeout(() => {
viewMeshRecheckTimer = null;
if (toolbarBlock !== recheckBlock) return;
updateSimplifiedToolbar();
if (toolbarKeyboardMode) renderBadges();
}, 400);
}

function updateSimplifiedToolbar() {
const block = toolbarBlock;
if (!block) return;
Expand Down Expand Up @@ -1174,19 +1185,7 @@ export function initContextMenus(workspace) {
// re-rendering badges.
if (e.type === Blockly.Events.BLOCK_MOVE) {
updateSimplifiedToolbar();
// Reattaching can create a mesh (detaching destroys one), but that
// happens via debounced code re-execution — it may not have landed
// yet. Check again shortly after so View catches up.
clearTimeout(viewMeshRecheckTimer);
const recheckBlock = toolbarBlock;
viewMeshRecheckTimer = setTimeout(() => {
viewMeshRecheckTimer = null;
if (toolbarBlock !== recheckBlock) return;
updateSimplifiedToolbar();
// viewBtn's visibility may have just changed; the badge overlay
// was last drawn against the old state, so refresh it too.
if (toolbarKeyboardMode) renderBadges();
}, 400);
scheduleViewMeshRecheck();
}
positionBlockToolbar();
} else if (
Expand All @@ -1206,6 +1205,8 @@ export function initContextMenus(workspace) {
e.blockId === toolbarBlock.id
) {
updateEnableButton(toolbarBlock);
updateSimplifiedToolbar();
scheduleViewMeshRecheck();
} else if (e.type === Blockly.Events.BLOCK_DRAG && e.isStart) {
// A keyboard-initiated move (M) fires this the same as a pointer
// drag; flag the block so the SELECTED handler above ignores the
Expand Down
Loading