Conversation
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
📝 WalkthroughWalkthroughDocumentation updates for Fluent Bit version 4.2.3 across Docker and Windows installation guides. Docker tags added for debug and release images. Windows installer versions, checksums, and URLs updated from 4.2.2 to 4.2.3. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@installation/downloads/docker.md`:
- Line 46: The table row referencing release v4.2.3 contains a broken
announcement link and should be removed or deferred; find the table row that
contains the version string "4.2.3" (the line with "v4.2.3" and the announcement
URL) and either delete that entire row or comment it out/replace it with a
placeholder until the announcement page at
https://fluentbit.io/announcements/v4.2.3/ is published, ensuring the release
table only contains valid links.
In `@installation/downloads/windows.md`:
- Line 131: Update the sentence containing the phrase "These are now using the
Github Actions built versions." to correct branding and hyphenation by replacing
"Github" with "GitHub" and changing "Actions built" to the compound modifier
"Actions-built" so the phrase becomes "These are now using the GitHub
Actions-built versions."; ensure the rest of the sentence ("Legacy AppVeyor
builds are still available (AMD 32/64 only) at releases.fluentbit.io but are
deprecated.") remains unchanged.
|
|
||
| <!-- vale on --> | ||
|
|
||
| These are now using the Github Actions built versions. Legacy AppVeyor builds are still available (AMD 32/64 only) at releases.fluentbit.io but are deprecated. |
There was a problem hiding this comment.
Fix capitalization and hyphenation: "Github Actions built" → "GitHub Actions-built".
"Github" should be "GitHub" (official brand capitalization), and "Actions built" used as a compound modifier before a noun needs a hyphen.
✏️ Proposed fix
-These are now using the Github Actions built versions. Legacy AppVeyor builds are still available (AMD 32/64 only) at releases.fluentbit.io but are deprecated.
+These are now using the GitHub Actions-built versions. Legacy AppVeyor builds are still available (AMD 32/64 only) at releases.fluentbit.io but are deprecated.🧰 Tools
🪛 LanguageTool
[grammar] ~131-~131: Use a hyphen to join words.
Context: ... These are now using the Github Actions built versions. Legacy AppVeyor builds a...
(QB_NEW_EN_HYPHEN)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@installation/downloads/windows.md` at line 131, Update the sentence
containing the phrase "These are now using the Github Actions built versions."
to correct branding and hyphenation by replacing "Github" with "GitHub" and
changing "Actions built" to the compound modifier "Actions-built" so the phrase
becomes "These are now using the GitHub Actions-built versions."; ensure the
rest of the sentence ("Legacy AppVeyor builds are still available (AMD 32/64
only) at releases.fluentbit.io but are deprecated.") remains unchanged.
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
|
Fluent Bit v4.2.3 is already shipped. |
eschabell
left a comment
There was a problem hiding this comment.
@cosmo0920 left comments for two things that need to be addressed, see what you think?
|
|
||
| <!-- vale on --> | ||
|
|
||
| These are now using the Github Actions built versions. Legacy AppVeyor builds are still available (AMD 32/64 only) at releases.fluentbit.io but are deprecated. |
|
@cosmo0920 I just noticed that the announcement blog is in the website repo, but not posting under announcements... i will fix that website issue fluent/fluent-bit-website-hugo#131 and then merge this PR here. |
Update release 4.2.3 version.
Summary by CodeRabbit