Skip to content

re-run job change status to InProgress#4983

Merged
jtmcdole merged 14 commits intomainfrom
183601-re-run-state
Mar 13, 2026
Merged

re-run job change status to InProgress#4983
jtmcdole merged 14 commits intomainfrom
183601-re-run-state

Conversation

@ievdokdm
Copy link
Contributor

@ievdokdm ievdokdm commented Mar 12, 2026

Decrease failed count for re-run.
Made status inProgress while at least one build is running.

Also archived conductor track of a previous task.

Fixes: flutter/flutter#183601

@github-actions
Copy link

🤖 Hi @ievdokdm, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This Pull Request successfully aims to fix an issue where re-running jobs causes the check suite to incorrectly reflect a failed status instead of in-progress. While the change to the GuardStatus logic resolves the core issue, an unintended state manipulation in the check run update logic introduces severe side effects.

🔍 General Feedback

  • State Integrity: The change in unified_check_run.dart decrements failedBuilds prematurely, which will crash the completion handler on a successful re-run and falsely report a success on a failed re-run. This specific file change should be reverted.
  • Edge Cases: The new GuardStatus logic is sound for the reported bug but introduces an infinite waitingForBackfill state when evaluating a check suite with zero tasks. Reordering the checks ensures this edge case continues to return succeeded.

@ievdokdm ievdokdm requested a review from jtmcdole March 12, 2026 20:13
@ievdokdm ievdokdm requested a review from jtmcdole March 12, 2026 23:46
@ievdokdm ievdokdm added the autosubmit Merge PR when tree becomes green via auto submit App. label Mar 12, 2026
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App. label Mar 12, 2026
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 12, 2026

autosubmit label was removed for flutter/cocoon/4983, because This PR has not met approval requirements for merging. Changes were requested by {jtmcdole}, please make the needed changes and resubmit this PR.
The PR author is a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@ievdokdm ievdokdm added the autosubmit Merge PR when tree becomes green via auto submit App. label Mar 13, 2026
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 13, 2026

auto label is removed for flutter/cocoon/4983, Failed to merge flutter/cocoon/4983 with Pull request flutter/cocoon/4983 could not be merged: Required status check "ci.yaml validation" is expected..

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App. label Mar 13, 2026
@ievdokdm ievdokdm added autosubmit Merge PR when tree becomes green via auto submit App. CICD Run CI/CD labels Mar 13, 2026
@jtmcdole
Copy link
Member

As admin, I'm bypassing the merge requirements because tests are passing and the review is in; tomorrow cicd label will work for cocoon.

@jtmcdole jtmcdole merged commit 49b5564 into main Mar 13, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App. CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-run failed job does not change guard status to In Progress

2 participants