re-run job change status to InProgress#4983
Conversation
…st one build is nurring.
|
🤖 Hi @ievdokdm, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
📋 Review Summary
This Pull Request successfully aims to fix an issue where re-running jobs causes the check suite to incorrectly reflect a failed status instead of in-progress. While the change to the GuardStatus logic resolves the core issue, an unintended state manipulation in the check run update logic introduces severe side effects.
🔍 General Feedback
- State Integrity: The change in
unified_check_run.dartdecrementsfailedBuildsprematurely, which will crash the completion handler on a successful re-run and falsely report a success on a failed re-run. This specific file change should be reverted. - Edge Cases: The new
GuardStatuslogic is sound for the reported bug but introduces an infinitewaitingForBackfillstate when evaluating a check suite with zero tasks. Reordering the checks ensures this edge case continues to returnsucceeded.
…en re-run requested so `markConclusion` should handle re-runned checks same way it handle it for the first time run
…d Details' as complete
… Presubmit Guard Details'
|
autosubmit label was removed for flutter/cocoon/4983, because This PR has not met approval requirements for merging. Changes were requested by {jtmcdole}, please make the needed changes and resubmit this PR.
|
|
auto label is removed for flutter/cocoon/4983, Failed to merge flutter/cocoon/4983 with Pull request flutter/cocoon/4983 could not be merged: Required status check "ci.yaml validation" is expected.. |
|
As admin, I'm bypassing the merge requirements because tests are passing and the review is in; tomorrow cicd label will work for cocoon. |
Decrease failed count for re-run.
Made status inProgress while at least one build is running.
Also archived conductor track of a previous task.
Fixes: flutter/flutter#183601