Fix disconnect reconnect#9878
Open
khanak0509 wants to merge 7 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a manual 'Reconnect' button to the disconnected screen in DevTools, allowing users to attempt reconnection to the last known VM service. Feedback on the changes highlights two key improvements: first, guarding the reconnection process against concurrent attempts since Dart's Future.timeout() does not cancel the underlying operation, and second, replacing the raw string 'uri' with the established named constant DevToolsQueryParams.vmServiceUriKey to comply with the repository's style guide.
srawlins
approved these changes
Jul 2, 2026
srawlins
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9838
This PR fixes issue #9838 where the DevTools Inspector was getting stuck disconnected after the Mac went to sleep and woke back up, like it just showed a dead Run a new debug session to reconnect message with no actual way to reconnect, even though the app was still running fine the whole time.
I added a Reconnect button to the disconnected overlay that reuses the last known VM service URI to reconnect, so you don't have to restart your whole debug session just because your laptop slept
issue.mov
Pre-launch Checklist
General checklist
///).Issues checklist
contributions-welcomeorgood-first-issuelabel.contributions-welcomeorgood-first-issuelabel. I understand this means my PR might take longer to be reviewed.Tests checklist
AI-tooling checklist
Feature-change checklist
release-notes-not-requiredlabel or left a comment requesting the label be added.packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md.If you need help, consider asking for help on Discord.