[two_dimensional_scrollables] Fixes TreeView crash when empty or last node collapsed

[Piinks]

This PR provides a robust fix for a crash in TreeView and resolves a regression introduced by a previous partial fix in PR #9103.

Previous attempts to fix the "empty tree" crash (shrinking to 0 rows) by moving _updateScrollBounds to the end of layout introduced a subtle inconsistency. When a node collapse triggered a scroll correction, the visible row range was recalculated after the layout loop had finished. This resulted in the paint phase attempting to access children that were never built, causing a null dereference (as seen in the Expand then collapse with offscreen nodes (top) test).

• _updateVerticalScrollBounds is now called before the child layout loop. This ensures that any vertical scroll corrections (e.g., clamping when content shrinks) happen first, so the layout loop builds exactly the rows that will be visible.
• Accurate Extent Calculation: Updated _updateScrollBounds to calculate the vertical scroll extent using the total height of all rows in _rowMetrics (via _rowMetrics.last.trailingOffset). This provides a consistent maxScrollExtent and correctly handles the "empty tree" state.
• Correct Horizontal Bounds: Updated the horizontal extent calculation to use absolute content-relative positions, ensuring correct scroll bounds when scrolling horizontally.

Fixes flutter/flutter#164981

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the AI contribution guidelines and understand my responsibilities, or I am not using AI tools.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I followed the version and CHANGELOG instructions, using semantic versioning and the repository CHANGELOG style, or I have commented below to indicate which documented exception this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

[gemini-code-assist]

Code Review

This pull request updates the two_dimensional_scrollables package to version 0.5.2, addressing a crash in TreeView that occurred when the view shrunk to zero rows or when the last node was collapsed. The changes include safe-guarding the vertical extent calculation against empty row metrics and ensuring the layout loop only executes when rows are present. New test cases verify these fixes and ensure scroll bounds are updated correctly. Feedback indicates that the horizontal extent calculation should be updated to use content-relative positions to ensure correct scroll bounds during horizontal scrolling.

[AbdeMohlbi]

LGTM with two small nits, i don't know why i don't like the new changelog entry can we change it 😅?

[Piinks]

Thank you for the review! 💙

[AbdeMohlbi]

Thank you for the review! 💙

Cash or card 🤓 ?

[Piinks]

I made a small tweak in the last commit. There was a recent refactor in the framework of the 2d foundation, and so when I fixed this, it was based off of that. Made it more robust so it is fixed for before and after the framework change. 👍

[Piinks]

Ah ha. Ok interesting. Taking another look. I want to avoid bumping the min Flutter SDK version if I can.