Skip to content

[camera_android_camerax] Pass targetVideoEncodingBitRate to Recorder#11960

Open
Anantha-Eswar wants to merge 2 commits into
flutter:mainfrom
Anantha-Eswar:fix-camerax-bitrate
Open

[camera_android_camerax] Pass targetVideoEncodingBitRate to Recorder#11960
Anantha-Eswar wants to merge 2 commits into
flutter:mainfrom
Anantha-Eswar:fix-camerax-bitrate

Conversation

@Anantha-Eswar

Copy link
Copy Markdown

This PR fixes an issue where the videoBitrate parameter configured in MediaSettings was ignored during video recording on Android using CameraX.

We now forward mediaSettings?.videoBitrate as the targetVideoEncodingBitRate when instantiating the CameraX Recorder instance in AndroidCameraCameraX.createCameraWithSettings.

Fixes flutter/flutter#179832

Pre-Review Checklist

@google-cla

google-cla Bot commented Jun 23, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the camera_android_camerax package to version 0.7.3, fixing an issue where the videoBitrate configuration was ignored during video recording. The Recorder is now instantiated with targetVideoEncodingBitRate mapped from mediaSettings?.videoBitrate, and unit tests have been updated to verify this configuration. There are no review comments, and I have no feedback to provide.

@stuartmorgan-g stuartmorgan-g added the triage-android Should be looked at in Android triage label Jun 23, 2026
@stuartmorgan-g stuartmorgan-g requested a review from camsim99 June 23, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: camera triage-android Should be looked at in Android triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[camera_android_camerax] videoBitrate parameter from MediaSettings is ignored

2 participants