refactor: improve AndroidAlarmManager example with null-safety and cleaner code #3727
+46
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Overview Refactor the AndroidAlarmManager example app for better readability, null-safety, and maintainability. ### Changes - Added null-safety improvements - Refactored button handlers into separate functions - Used `final` and `const` where applicable - Cleaned up logging and documentation - Preserved functionality ### Impact - No API changes - No behavioral changes - Ready for Flutter stable >=3.0
Collaborator
|
Same conclusion as in #3726. I see that you didn't even bother to fill the PR description properly. Based on 2 PRs of questionable quality I would ask you to avoid contributing to this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactor the AndroidAlarmManager example app for better readability, null-safety, and maintainability.
Changes
finalandconstwhere applicableImpact
Description
Related Issues
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).