Enforce strict selector validation in getStyleAny and add comprehensive unit tests #556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)Closes #64218
This PR resolves an issue in getStyleAny where invalid or partially-matching CSS selectors were incorrectly treated as valid. This behavior allowed users to pass certain curriculum challenges without meeting the required selector constraints.
The fix ensures that only exact matches from the allowed selector list are accepted.
This update improves reliability of curriculum challenge tests such as:
Lab Book Inventory App – Selector Validation
(ref: freeCodeCamp discussions / provided link)
What Was Done
✔ Fixed selector matching logic
Updated the getStyleAny function to prevent:
Partial matching
Attribute-selector misuse
Acceptance of selectors not explicitly allowed
✔ Added complete test coverage
Introduced getStyleAny.test.ts containing:
A failing test for previously-passing invalid selectors
A passing test for correct exact-match selectors